Use enums for settings in SRAM header #2429
Conversation
include/z64sram.h
Outdated
| /* 0x00 */ SRAM_HEADER_SOUND, | ||
| /* 0x01 */ SRAM_HEADER_ZTARGET, | ||
| /* 0x00 */ SRAM_HEADER_AUDIO, |
There was a problem hiding this comment.
it was previously called "sound" because that is what it is called in file select. And the options in the sram header correspond directly with the options in file select.
Currently thinking it makes sense to stay aligned with file select, but more thoughts welcome
There was a problem hiding this comment.
I'd like to rename gSaveContext.audioSetting and AudioSetting too then. What should we call those? And what about what is now SoundMode?
There was a problem hiding this comment.
good question. would like to get @engineer124 involved if he sees this. will put some thought into it in the meantime
There was a problem hiding this comment.
coming back to this, I think I would be okay with SoundSetting for the file select-side value, and SoundMode for the internal value.
Its not perfect but we can just do that for now and get this moving
There was a problem hiding this comment.
sound good thanks, I updated the PR with that (pending bss fixes)
Dragorn421
added
Met Review Requirements
and removed
Needs first approval
Needs second approval
labels
|
hm I thought the audio library was supposed to be self-contained though |
|
|
|
Right, the value has meaning in save context and file select. Seems to me like it should live in save.h. The audio system doesnt care about the setting value except for that one translation layer function |
|
build failed again |
I put the
AudioSettingenum in z64audio.h since it's used in audio code, but confusingly there's also theSoundModeenum which is almost the same but isn't. I named the function that translates between them asAudio_SetAudioSettingbut this name feels doubly redundant. Suggestions welcome